Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Different Share Icon depending on loged in/of state #50

Closed
SerenaButler opened this issue Mar 10, 2019 · 4 comments
Closed

Different Share Icon depending on loged in/of state #50

SerenaButler opened this issue Mar 10, 2019 · 4 comments

Comments

@SerenaButler
Copy link

image

@ildyria
Copy link
Member

ildyria commented Mar 10, 2019

I did not chose the icons, electrious did. I think the eye is a reference to "visibility".

@SerenaButler
Copy link
Author

Yes but in includes the same sharing subset as when not logged. It's a bit inconsistent. Anyway :-)

@d7415
Copy link
Contributor

d7415 commented Mar 10, 2019

My understanding is that the eye started as public/private, but then sharing options were added there. It makes no sense to be the eye when not logged in, as you cannot set that.

@bennettscience was suggesting we change it in #26. I quite like the eye. I'm generally against extra menus, but maybe it makes sense here to split owner-level and public-level "sharing" options.

@ildyria ildyria transferred this issue from LycheeOrg/Lychee Mar 12, 2019
@kamil4
Copy link
Contributor

kamil4 commented Aug 28, 2019

This was resolved in #134.

@kamil4 kamil4 closed this as completed Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants