This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
Sharing #134
Merged
Sharing #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kamil4
commented
Aug 15, 2019
kamil4
commented
- New share icon and a copy to clipboard icon
- Split visibility and sharing icons in album and photo views
- Rework album sharing to have all controls in a single dialog box; support preserving of the current password (requires server-side changes)
- Get rid of "hidden" which wasn't there in v3 and is redundant
- Use green and orange for the visibility icon, as appropriate
- Add a photo sharing dialog box to match album sharing
- Support the download of all image sizes (v4 only; requires server-side changes)
- Add a copy-to-clipboard option for albums and a dialog box for all image sizes; get rid of the read-only input box
- Make loading bar notifications easier to see when a dialog window is open
- Fix individual photo sharing display in the info sidebar
- Change the badge colors of the Public smart album and individually shared photos to orange
- Fix the most recent breakage in the standalone view
- Add support for sliders and disabled checkboxes to basicModal.
|
Code wise it looks good to me. |
|
@ildyria Are you sure? I just tested with 76.0.3809.87 under Linux and copy to clipboard works fine here... Are you getting some error or the expected "OK: Copied URL to clipboard!" notification? On a somewhat unrelated note, I notice that the first link in Direct Links (in photo view) is selected in Chrome, which I went to some pain to avoid, but apparently I was only successful with that goal under Firefox. I'll see if I can get that figured out... |
Don't reset additional visibility properties when making album private. Preserve album password across visibility edits. Add support for sliders to basic modals.
Add support for disabling to sliders. Make the global downloadable config easily accessible. Reset additional album visibility properties when making album private after all.
Remove the read-only URL inputs from the menu. Support for copying URLs to the clipboard. Formatting changes.
Adjust spacing/margins in new dialog windows. Add the copy icon from ionicons.
This was referenced Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.