Skip to content
This repository has been archived by the owner on May 3, 2021. It is now read-only.

Updated translation for v3.2.8, fixes, spell check #161

Merged
merged 2 commits into from
Jan 1, 2019

Conversation

anroth76
Copy link
Contributor

Updated German locale for Lychee v3.2.8, synced line numbers with English.php, fixed/improved some expressions, spelling and punctuation.

Updated German locale for Lychee v3.2.8, synced line numbers with English.php, fixed/improved some expressions, spelling and punctuation.
@ildyria
Copy link
Member

ildyria commented Dec 31, 2018

Thank you for your PR. 👍 :)

Could you please use tabs instead of space for indentation ? :s

@ildyria ildyria self-requested a review December 31, 2018 00:04
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you are missing some lines from https://github.com/LycheeOrg/Lychee-front/blob/master/scripts/lychee_locale.js
I forgot to add them in English.php. Will do soon (sorry for that).

@anroth76
Copy link
Contributor Author

Thank you for your PR. 👍 :)

Could you please use tabs instead of space for indentation ? :s

I copied the code from my local copy in Notepad++, apparently, my browser might have screwed up something (I'm all new to GitHub). I noticed that some stuff is missing, like the labels for the buttons in the upper right corner, will check the lychee_locale.js if I can find those. :)

Copied missing strings from lychee_locale.js, changed identation from spaces to tabs.
@ildyria
Copy link
Member

ildyria commented Dec 31, 2018

like the labels for the buttons in the upper right corner

Yeah that is something we cannot change in the current version of Lychee (v3). The next version should be able solve this (available at your own risk here: https://github.com/ildyria/Lychee-Laravel ).

Fortunately we just need to copy paste the lang folder. :)
However the label have not been translated yet. :|

@ildyria ildyria merged commit 1bedbf1 into LycheeOrg:master Jan 1, 2019
@anroth76
Copy link
Contributor Author

anroth76 commented Jan 1, 2019

Aw man, just when you think you got everything... I found another typo in line 323: "Foto-Manaagement" should be "Foto-Management", naturally. Maybe it's quicker if you fix it in the master files yourself?

@d7415
Copy link
Contributor

d7415 commented Jan 1, 2019

Aw man, just when you think you got everything... I found another typo in line 323: "Foto-Manaagement" should be "Foto-Management", naturally. Maybe it's quicker if you fix it in the master files yourself?

On it...

d7415 added a commit that referenced this pull request Jan 1, 2019
@d7415
Copy link
Contributor

d7415 commented Jan 1, 2019

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants