Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Add "Clear" button to logs #302

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Add "Clear" button to logs #302

merged 2 commits into from
Jul 20, 2022

Conversation

qwerty287
Copy link
Contributor

No description provided.

@qwerty287 qwerty287 requested review from ildyria, nagmat84 and kamil4 and removed request for ildyria and nagmat84 June 16, 2022 16:53
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I missed a discussion on this, so I might be simply missing context. Is this supposed to completely clear the logs, whereas "clean noise" removes only debug messages and such? I feel like this might be too fine a distinction for the end users -- I worry we will forever get questions about the difference between "clean" and "clear"? Do we really need both? I feel like we should possibly keep just one (and that may very well be the new "Clear").

@qwerty287
Copy link
Contributor Author

"Clear" removes everything, "Clean Noise" only messages with type notice. Keeping only clear might be a better idea. Any other thoughts? I'd like it, but I'm fine with having both too.

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qwerty287 qwerty287 merged commit 7db1773 into master Jul 20, 2022
@qwerty287 qwerty287 deleted the clean-logs branch July 20, 2022 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants