Custom album covers #239
Custom album covers #239
Conversation
context menu on photos allows to set/remove cover of parent allbum IMPORTANT: this is abusing album.description to store id of cover photo (needs to be changed once album table includes column for covers) IMPORTANT: something seems amiss with the gulpfile because iconic.svg does not get processed (the new icon needs to be manually added to resources/views/includes/svg.blade.php and resources/views/view.blade.php) IMPORTANT: support for 3 distinct images for albums dropped (overkill given that 2 are barely visible)
extend context menu for selecting the cover of a submenu as the custom cover of the parent
|
OK, I added the missing pieces for selecting a subalbum as cover; can you guys test? Smart albums now display "public" badge for if the Starred or Recent albums are public. I'm undecided if I like that or not... It's probably an improvement, although I may tweak the ordering... |
|
Kudos, SonarCloud Quality Gate passed!
|
|
I'm unsure about having the cover badge showing up for albums. For pictures it is pretty obvious but for album I feel this is overkill. 🤔 |
I don't get it. To me they seem like exactly the same case? A user can select for a cover of an album either a photo from the album as or a cover from a subalbum. In either case we give the same visual indication. Why should one be obvious and the other an overkill? |
|
I will check. :) |
|
In my original attempt only the context menu entry and the colour of its accompanying icon changed for a currently selected photo/sub album. This was subtle to the point of obscurity... I am with @kamil4 and already got totally used to the badges. My initial concerns with them completely evaporated after @ildyria pointed out that badges are only visible for the owner of the album. |
Draft pull request to implement setting custom cover images for albums, see LycheeOrg/Lychee#442
This pull request implements the front end for setting custom album covers by extends the context menu for photos and albums with Set/Remove Album cover to set/remove custom album covers of the parent album. The corresponding changes in the back end are in a separate pull request LycheeOrg/Lychee#875
IMPORTANT:
album.descriptionto store the information of custom covers. It requires a new columncoverin thealbumtable, which is beyond my pay grade.AlbumController.phpshould be reviewed (this is completely unfamiliar territory...)