Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vite compilation step & DROP ARMV6 #168

Merged
merged 11 commits into from
Dec 24, 2023
Merged

Add vite compilation step & DROP ARMV6 #168

merged 11 commits into from
Dec 24, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Dec 24, 2023 •
edited
Loading

Inspired from the Dockerfile from fly.io

@ildyria ildyria requested a review from d7415 December 24, 2023 19:52
@ildyria ildyria mentioned this pull request Dec 24, 2023
Merged
18 tasks
d7415
d7415 reviewed Dec 24, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@ildyria @d7415
Update Dockerfile
5fa3e63 
Co-authored-by: Martin Stone <1611702+d7415@users.noreply.github.com>
d7415
d7415 approved these changes Dec 24, 2023
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, go for it. I'll see if I can make anything cleaner later.

@ildyria ildyria changed the title Add vite compilation step [urgent] Add vite compilation step & DROP ARMV6 Dec 24, 2023
@ildyria ildyria merged commit a1a5a59 into master Dec 24, 2023
1 check passed
@ildyria ildyria deleted the vite branch December 24, 2023 23:09
d7415 added a commit that referenced this pull request Dec 27, 2023
@d7415
Tidy up #168, #170
d10de82 
- Drop armv6 in README
- Remove unnecessary rsync step
- Remove some comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415