drop Lux "branding" #52

CarloLucibello · 2024-07-10T05:22:46Z

Some comments

Package name has to be finalized, I used DeviceUtils.jl for the time being/
I dropped the LuxCUDA extension as it is not really required for data movement. We now have only the CUDA extension. We give warnings if cuDNN is not installed though and point to either using CUDA, cuDNN or using LuxCUDA.
Except for the CUDA extension, everything else is just renaming.

codecov · 2024-07-10T05:58:48Z

Codecov Report

Attention: Patch coverage is 24.57143% with 132 lines in your changes missing coverage. Please review.

Project coverage is 38.72%. Comparing base (4936a4e) to head (25f3c4f).

Files	Patch %	Lines
ext/DeviceUtilsAMDGPUExt.jl	0.00%	49 Missing ⚠️
ext/DeviceUtilsCUDAExt.jl	0.00%	44 Missing ⚠️
ext/DeviceUtilscuDNNExt.jl	0.00%	13 Missing ⚠️
ext/DeviceUtilsMetalExt.jl	0.00%	7 Missing ⚠️
src/DeviceUtils.jl	78.12%	7 Missing ⚠️
ext/DeviceUtilsoneAPIExt.jl	0.00%	6 Missing ⚠️
ext/DeviceUtilsTrackerExt.jl	62.50%	3 Missing ⚠️
ext/DeviceUtilsFillArraysExt.jl	50.00%	1 Missing ⚠️
ext/DeviceUtilsGPUArraysExt.jl	0.00%	1 Missing ⚠️
ext/DeviceUtilsZygoteExt.jl	50.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4936a4e) and HEAD (25f3c4f). Click for more details.

HEAD has 2 uploads less than BASE

Flag BASE (4936a4e) HEAD (25f3c4f)

6 4

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #52       +/-   ##
===========================================
- Coverage   85.81%   38.72%   -47.10%     
===========================================
  Files          13       13               
  Lines         289      297        +8     
===========================================
- Hits          248      115      -133     
- Misses         41      182      +141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ext/DeviceUtilsCUDAExt.jl

test/runtests.jl

CarloLucibello · 2024-07-10T16:07:10Z

not sure why coverage dropped

avik-pal · 2024-07-10T16:29:53Z

not sure why coverage dropped

Buildkite doesn't give forks access to secrets. That is fine, I can open a PR from your branch and it will work

avik-pal · 2024-07-10T16:32:09Z

Overall looks good, I will pull it into #53 and merge as 1.0 once the other packages are also ready for the tag.

ext/DeviceUtilsCUDAExt.jl

Project.toml

CarloLucibello · 2024-07-13T07:21:14Z

should I rebase?

avik-pal · 2024-07-13T15:08:32Z

Yeah do a rebase. But I will merge this together with the 1.0 pr

cleanup cleanup fix improve docstring require cuDNN none functional only if cuDNN is functional separate cuDNN extension cleanup