Follow standards for javascript "data-" attribute names #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should not alter functionality anywhere. Simply a code cleanup to make the attributes on the SPAN tags wrapping each word use the HTML data-* attribute standards.
Changed attributes
in places where jQuery is used, references to
$(element).attr('data_some_attribute')
were changed to$(element).data('some-attribute')
where vanilla Javascript was used, references to
element.getAttribute('data_some_attribute')
were changed toelement.dataset.someAttribute