Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio player first pass #48

Closed
wants to merge 1 commit into from
Closed

Conversation

webofpies
Copy link
Contributor

First pass for audio player

There's a temporary "browse" button for adding an audio file to the player. This button won't be there for the final version probably.

What needs to be implemented on back end:

  1. storing bookmark positions (from 1 to 99 probably) for later retrieving
  2. storing last play position (from 1 to 99 probably) so user can resume immediately when reopening a book. Variable "lastPlayTime" is already declared and used in the script.

image

@jzohrab jzohrab changed the base branch from master to develop December 7, 2023 23:19
@jzohrab
Copy link
Collaborator

jzohrab commented Dec 7, 2023

Super, thanks very much!

The PR touches a few lines of code it shouldn't, looks like your editor was auto-reformatting some files. In some cases those suggested changes are good. I'll try working with the commit in a feature branch.

@jzohrab
Copy link
Collaborator

jzohrab commented Dec 8, 2023

Closing in favor of feature branch in PR #49 -- Lute itself needs some work to properly support this change.

@jzohrab jzohrab closed this Dec 8, 2023
@webofpies webofpies deleted the audio branch January 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants