Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add words per page in the book creation page #153

Closed
wants to merge 7 commits into from

Conversation

fanyingfx
Copy link
Contributor

No description provided.

@jzohrab
Copy link
Collaborator

jzohrab commented Jan 25, 2024

Thanks @fanyingfx 👍

I'm looking at the branch now. Some of the code should be moved into the domain model so I'm making adjustments in my own branch (off of yours). When it's done I'll PR back into your branch.

I've also re-arranged the form fields: the max word count belongs next to the text fields.

I've also decrease the min word count to 10. That number might seem very low, but for complete beginners in a language, seeing something sentence-by-sentence might be useful. The default is still 250, and max is what you set it as.

@jzohrab
Copy link
Collaborator

jzohrab commented Jan 25, 2024

@fanyingfx , I PR'd back into your branch :-) but we can also just merge my branch into develop, as it has your commits and mine. Take a peek at the PR (fanyingfx#1) -- cheers!

Add max tokens to domain model, change field order
@fanyingfx
Copy link
Contributor Author

Thanks jz, your adjustments make code better consistency and more user-friendly. And I think using your branch is better for the project management. I think I can close this pr.

@jzohrab
Copy link
Collaborator

jzohrab commented Jan 25, 2024

Hi @fanyingfx , I've opened a PR from my branch to develop: #157. We can chat there if needed. Take a look, LMK if any questions etc. Thx for getting this started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants