-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotkey arrow up and down to increase/decrease status number #33
Comments
I have a pull request just about ready to go for this, but I wanted to double check the multiple terms case. In the case where I have three terms selected with different status levels. Let's say:
Upon clicking the up arrow, is the desired behavior the following?
If I understand the multiple terms description above, the terms should increment/decrement relative to their original status, with a max of To illustrate a little further, repeated up arrows would eventually end up with everything as If that sounds correct, I'll do one more pass through the code and send a PR. |
Thats better than what I was thinking, I figured they’d all get set to the
same thing (the lowest). :-)
El El vie, dic. 8, 2023 a la(s) 8:05 a. m., Robby Macdonell <
***@***.***> escribió:
… I have a pull request just about ready to go for this, but I wanted to
double check the multiple terms case.
In the case where I have three terms selected with different status
levels. Let's say:
- una: Well-known
- escuela: Level 5
- basura: Level 1
Upon clicking the up arrow, is the desired behavior the following?
- una: Well-known (no change)
- escuela: Level Well-known
- basura: Level 2
If I understand the multiple terms description above, the terms should
increment/decrement relative to their original status, with a max of
well-known and a min of 1. Does that sound correct?
To illustrate a little further, repeated up arrows would eventually end up
with everything as well-known, and repeated down arrows would eventually
end up with everything as status 1.
If that sounds correct, I'll do one more pass through the code and send a
PR.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMPWDNOMHFB3I6U4WRTJLTYIJKTLAVCNFSM6AAAAAA75G2YW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGI4TEMJQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Actually based on the above, "If multiple terms chosen, could just start with the lowest status" -- having them all be the same would be easiest to do: loop through all of them, get the lowest, then ajax that value incremented or decremented. But if you've already done the other more complicated way, that's good too! |
Hotkey left-right moves to terms, so up/down could change status.
Would need to go up related to the current status. If multiple terms chosen, could just start with the lowest status. Go from 1-2-3-4-5-WellKnown, skip "ignored".
The function to update is in lute.js,
handle_keydown
-- at least, that is how I was intending to do it. If there is a better option, LMK.The text was updated successfully, but these errors were encountered: