Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey arrow up and down to increase/decrease status number #33

Closed
jzohrab opened this issue Nov 28, 2023 · 3 comments
Closed

Hotkey arrow up and down to increase/decrease status number #33

jzohrab opened this issue Nov 28, 2023 · 3 comments
Labels
fixed Fixed in develop or master, to be launched.

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Nov 28, 2023

Hotkey left-right moves to terms, so up/down could change status.

Would need to go up related to the current status. If multiple terms chosen, could just start with the lowest status. Go from 1-2-3-4-5-WellKnown, skip "ignored".

The function to update is in lute.js, handle_keydown -- at least, that is how I was intending to do it. If there is a better option, LMK.

@robby1066
Copy link
Contributor

I have a pull request just about ready to go for this, but I wanted to double check the multiple terms case.

In the case where I have three terms selected with different status levels. Let's say:

  • una: Well-known
  • escuela: Level 5
  • basura: Level 1

Upon clicking the up arrow, is the desired behavior the following?

  • una: Well-known (no change)
  • escuela: Level Well-known
  • basura: Level 2

If I understand the multiple terms description above, the terms should increment/decrement relative to their original status, with a max of well-known and a min of 1. Does that sound correct?

To illustrate a little further, repeated up arrows would eventually end up with everything as well-known, and repeated down arrows would eventually end up with everything as status 1.

If that sounds correct, I'll do one more pass through the code and send a PR.

@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 8, 2023 via email

@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 8, 2023

Actually based on the above, "If multiple terms chosen, could just start with the lowest status" -- having them all be the same would be easiest to do: loop through all of them, get the lowest, then ajax that value incremented or decremented. But if you've already done the other more complicated way, that's good too!

@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Dec 11, 2023
@github-project-automation github-project-automation bot moved this to Done in Lute-v3 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed in develop or master, to be launched.
Projects
None yet
Development

No branches or pull requests

2 participants