Use CMake variables to enable/disable test apps #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't use environment variable GFXRECON_NO_TEST_APPS at the level of tests/ * Instead use CMake variable GFXRECON_INCLUDE_TEST_APPS, default ON To turn off test apps, provide "-DGFXRECON_INCLUDE_TEST_APPS=OFF" to CMake.
|
CI gfxreconstruct build queued with queue ID 355712. |
|
CI gfxreconstruct build # 5926 running. |
|
CI gfxreconstruct build # 5926 passed. |
|
CI gfxreconstruct build queued with queue ID 355769. |
|
CI gfxreconstruct build # 5928 running. |
|
CI gfxreconstruct build # 5928 passed. |
antonio-lunarg
approved these changes
Jan 27, 2025
|
We should modify the Github CI to use the new env variable so we're making sure the test apps keep compiling correctly. |
The default should be "ON" and my testing seems to verify that - default build on my Linux machine built the tests. Could you checkout and build this branch just to verify it does what you think it should do? |
beau-lunarg
approved these changes
Jan 27, 2025
bradgrantham-lunarg
added a commit
that referenced
this pull request
Jan 28, 2025
* use CMake GFXRECON_INCLUDE_TEST_APPS instead of GFXRECON_NO_TEST_APPS * Don't use environment variable GFXRECON_NO_TEST_APPS at the level of tests/ * Instead use CMake variable GFXRECON_INCLUDE_TEST_APPS, default ON To turn off test apps, provide "-DGFXRECON_INCLUDE_TEST_APPS=OFF" to CMake. * document change of variable and meaning for test app build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.