Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit with 0 if capture wasn't optimizable #1389

Merged
merged 4 commits into from
Dec 11, 2023
Merged

exit with 0 if capture wasn't optimizable #1389

merged 4 commits into from
Dec 11, 2023

Conversation

bradgrantham-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 96654.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3602 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 96666.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3603 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 96691.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3604 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 96704.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3605 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 96717.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3606 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3606 passed.

@bradgrantham-lunarg bradgrantham-lunarg requested review from charles-lunarg and removed request for panos-lunarg December 8, 2023 18:03
charles-lunarg
charles-lunarg approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nit is that I prefer giving member variables in classes default values (like false) rather than using an initializer list in a constructor, but that's not something to fix in this PR - just stating my preference.

Gave it a spin on my local machine and didn't see any cause for concern.

@charles-lunarg
Copy link
Contributor

If there was any PR to squash into a single commit, its this one due to the need to fix formatting issues.

@bradgrantham-lunarg
Copy link
Contributor Author

Only nit is that I prefer giving member variables in classes default values (like false) rather than using an initializer list in a constructor, but that's not something to fix in this PR - just stating my preference.

Gave it a spin on my local machine and didn't see any cause for concern.

I agree but I decided to match the existing style, which I think is important.

@bradgrantham-lunarg
Copy link
Contributor Author

If there was any PR to squash into a single commit, its this one due to the need to fix formatting issues.

omg clang-format

@bradgrantham-lunarg bradgrantham-lunarg merged commit 668850b into LunarG:dev Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradgrantham-lunarg @ci-tester-lunarg @charles-lunarg