Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AGS to convert tool, rebased. #1360

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

feimao-gfxr
Copy link
Contributor

Problem

  1. AGS support is already in GFXR. The convert output file should also include the AGS calls.
  2. The index values in the convert output file doesn't match anything in the replay consumer. It makes it very hard to find the matching call in the convert file when debugging an issue in the replayer.

Solution

  1. Add AGS ascii consumer to support AGS in the convert tool.
  2. Remove api_call_count_ from the convert consumer and use block index for index values in the convert output file. Block index values provides consistent matches between different decode consumers.

Result
AGS calls are included in the convert output file. Indices are block index values now.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 85829.

@feimao-gfxr
Copy link
Contributor Author

feimao-gfxr commented Nov 17, 2023

This PR is to replace PR #1211.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3526 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3526 passed.

@davidd-lunarg davidd-lunarg self-assigned this Apr 11, 2024
@bradgrantham-lunarg bradgrantham-lunarg added P1 Prevents an important capture from being replayed convert Issue with convert execution or output d3d12 Issue with D3D 12 support labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convert Issue with convert execution or output d3d12 Issue with D3D 12 support P1 Prevents an important capture from being replayed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants