Added handling missing VK_EXT_swapchain_colorspace #1287
Conversation
naomipappe
commented
Oct 2, 2023
naomipappe
commented
- Check whether the color space used by swapchain is supported by the replay device. Inform the user through log if it is not.
- Introduce an option, that when enabled, will fallback to supported color space for swapchain.
Move the replacement of color space under a newly created option. If the option is not enabled, log the usage of a color space from unsupported extension. Change-Id: I4e7dafb0b1deffb2700094e2b9f2ad201aab0b95
Fixing a wrong reference to colorspace fallback option Change-Id: I149397465888c9eaa360a1938e003aa91880e64b
|
CI gfxreconstruct build queued with queue ID 54099. |
|
CI gfxreconstruct build # 3317 running. |
|
CI gfxreconstruct build # 3317 passed. |
Change-Id: Idacaad4bee8345d8a2404c2313c07575c32f8b63
|
CI gfxreconstruct build queued with queue ID 55823. |
|
CI gfxreconstruct build # 3335 running. |
|
CI gfxreconstruct build # 3335 failed. |
Remove colorspace extension if it is unsupported. Change-Id: If7732ce1bee374a173597bece7f06f7b326db0a4
|
CI gfxreconstruct build queued with queue ID 69794. |
|
CI gfxreconstruct build # 3416 running. |
|
CI gfxreconstruct build # 3416 passed. |
bradgrantham-lunarg
added
the
P1
bradgrantham-lunarg
assigned bradgrantham-lunarg and charles-lunarg and unassigned charles-lunarg and bradgrantham-lunarg
Change-Id: I12de7a460b707f9a89bd301add624516c722a706
|
CI gfxreconstruct build queued with queue ID 78323. |
|
CI gfxreconstruct build # 3456 running. |
|
CI gfxreconstruct build # 3456 passed. |
|
Hi, @naomipappe , do you have any thoughts about the feedback from @charles-lunarg ? Thanks! |
|
Yes, I fully agree with the comments about reducing the code duplication, and I am currently looking into how code generation is done in gfxreconstruct to implement the automatically generated map to avoid code rot. |
automatic generation to be less susceptible to code rot Change-Id: I1fe6c95804ede957139b2974766033b8a87c82b2
|
CI gfxreconstruct build queued with queue ID 95516. |
|
CI gfxreconstruct build # 3598 running. |
|
CI gfxreconstruct build # 3598 passed. |
There was a problem hiding this comment.
Thank you for going through the somewhat laborious effort of making this generated rather than hardcoded. Makes the implementation a bit cleaner too I think, even if it involves more code.
I don't know if/when more swapchain formats will be added, but gfxr will handle it with ease now.
framework/generated/vulkan_generators/vulkan_constant_maps_generator.py
Outdated
Show resolved
Hide resolved
Python's set() doesn't maintain order, causing sporadic CI failures due to different generator output. Simply sort the set before printing to maintain order.
|
CI gfxreconstruct build queued with queue ID 95803. |
|
CI gfxreconstruct build # 3599 running. |
|
CI gfxreconstruct build # 3599 passed. |
