Write replay measurements into a JSON file - Finalised #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 50786. |
|
Arf, so sorry, and I did the same mistake with #1276 |
|
CI gfxreconstruct build # 3278 running. |
Marius measurements-file diffed against dev
Branch pushed to PR was merged with dev rather than rebased on top of
it so I diffed that branch against dev to make a commit equivalent to
rebasing and squashing it - Andrew.
Results from `--measurement-frame-range` can now be written to a JSON
file using the option `--measurement-file`.
This option is necessary to retrieve measurements in android
environments where logcat is not available. It also makes parsing
of the measurements by a script easier and allow more detailed
measurements without flooding the logcat.
Example of JSON output:
{
"application": {
"capture_name": "/sdcard/capture.gfxr"
},
"frame_range":
{
"duration": 2.365642154,
"end_frame": 200,
"end_time_monotonic": 15666.74495701,
"fps": 42.27182028816688,
"frame_count": 100,
"frame_durations": [
17316846,
26862231,
24499077,
24042769,
...
19480077,
16187384,
16081154,
18678846,
18439692
],
"start_frame": 100,
"start_time_monotonic": 15664.379314856
}
}
Co-authored-by: Andrew Cox <andrew@lunarg.com>
andrew-lunarg
force-pushed
the
andy-finalise-measurements-file
branch
from
c71f835 to
e42b57c
Compare
|
CI gfxreconstruct build queued with queue ID 50804. |
I did something like this to get a fresh new branch with your changes as a single commit after the head of dev: git diff dev yourbranch > patch.diff
git checkout dev
git checkout -b fresh_branch
git apply patch.diff |
|
CI gfxreconstruct build # 3279 running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1175 was merged with dev, mixing commits into the history and creating a merge commit, which we do not do. I would have had to rewrite history to do the required rebase and push to the original branch which I don't want to do so I made a fresh PR for the final rebase on dev. There were also a couple of small changes, one of which needed my knowledge of upcoming changes to the codebase so I went ahead and made them myself.