Added Requested TODO to Move Custom Code

LunarG · Dec 1, 2023 · d0b53fd · d0b53fd
1 parent 67dedce
commit d0b53fd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/framework/generated/dx12_generators/dx12_struct_decoders_to_json_body_generator.py b/framework/generated/dx12_generators/dx12_struct_decoders_to_json_body_generator.py
@@ -101,6 +101,8 @@ def beginFile(self, gen_opts):
 
             using util::JsonOptions;
 
+            // TODO Move all these manual functions out of the generator and into a .cpp file.
+
             /// @defgroup ManualD3D12StructFieldToJsons Manual functions to convert raw structs.
             /** @{ */
             static void FieldToJson(nlohmann::ordered_json& jdata, const D3D12_RENDER_PASS_BEGINNING_ACCESS_PRESERVE_LOCAL_PARAMETERS& data, const JsonOptions& options)
@@ -816,6 +818,8 @@ def makeUnionFieldToJson(self, properties, struct_name, union_index):
     def endFile(self):
         """Method override."""
         custom_impls = format_cpp_code('''
+            // TODO Move all these manual functions out of the generator and into a .cpp file.
+
             /// @defgroup custom_dx12_struct_decoders_to_json_bodies Custom implementations for
             /// troublesome structs.
             /// We put the custom implementations in the generator Python rather than

diff --git a/framework/generated/generated_dx12_struct_decoders_to_json.cpp b/framework/generated/generated_dx12_struct_decoders_to_json.cpp
@@ -40,6 +40,8 @@ GFXRECON_BEGIN_NAMESPACE(decode)
 
 using util::JsonOptions;
 
+// TODO Move all these manual functions out of the generator and into a .cpp file.
+
 /// @defgroup ManualD3D12StructFieldToJsons Manual functions to convert raw structs.
 /** @{ */
 static void FieldToJson(nlohmann::ordered_json& jdata, const D3D12_RENDER_PASS_BEGINNING_ACCESS_PRESERVE_LOCAL_PARAMETERS& data, const JsonOptions& options)
@@ -4515,6 +4517,8 @@ void FieldToJson(nlohmann::ordered_json& jdata, const Decoded__SECURITY_ATTRIBUT
     }
 }
 
+// TODO Move all these manual functions out of the generator and into a .cpp file.
+
 /// @defgroup custom_dx12_struct_decoders_to_json_bodies Custom implementations for
 /// troublesome structs.
 /// We put the custom implementations in the generator Python rather than