vkreplay: Fix issues replaying 32-bit large file #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32-bit Linux/Android, fseek and ftell only works well for trace file smaller than 2GB which will cause problem when geting file length and using portability table on a large trace file. This change fixes the issue by: * x86 version: ** Use fseeko and ftello instead of fseek and ftell. "-D_FILE_OFFSET_BITS=64" has been defined in vktrace's CMakeList.txt to make those functions support large file. * 32-bit Android version: ** Implement vktrace_fseek and vktrace_ftell using lseek64 which is available in NDK. For the NDK problem of using fseeko and ftello, refer to android/ndk#480
|
The builds in this pull request failed because of a process problem - the Vulkan-Tools build was broken when this pull request was submitted. Now that the Vulkan-Tools build has been fixed, I have verified that this pull request in fact does build successfully. I merged this change to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32-bit Linux/Android, fseek and ftell only works well for trace file
smaller than 2GB which will cause problem when geting file length and
using portability table on a large trace file.
This change fixes the issue by:
x86 version:
** Use fseeko and ftello instead of fseek and ftell.
"-D_FILE_OFFSET_BITS=64" has been defined in vktrace's CMakeList.txt to
make those functions support large file.
32-bit Android version:
** Implement vktrace_fseek and vktrace_ftell using lseek64 which is
available in NDK.
For the NDK problem of using fseeko and ftello, refer to
android/ndk#480