Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite embeds in on_page_markdown #75

Merged
merged 4 commits into from
Nov 9, 2024
Merged

Rewrite embeds in on_page_markdown #75

merged 4 commits into from
Nov 9, 2024

Conversation

LukeCarrier
Copy link
Owner

Fixes #72, but might break other use cases.

@LukeCarrier LukeCarrier self-assigned this Nov 1, 2024
@LukeCarrier LukeCarrier added the enhancement New feature or request label Nov 1, 2024
Pre-process the Markdown before it's converted to Markdown, improving
compatibility with other plugins.

There are breaking changes here:

- In the `embed_format` configuration option:
  - `img_open` and `img_close` are no longer valid placeholders.
  - `img_alt` and `img_src` replace them.
  - The new default is `<img alt="{img_alt}" src="{img_src}">`.

Fixes #72
@LukeCarrier LukeCarrier merged commit f56f3d1 into main Nov 9, 2024
6 checks passed
@LukeCarrier LukeCarrier deleted the on-page-markdown branch November 9, 2024 21:37
LukeCarrier added a commit that referenced this pull request Nov 10, 2024
Broke this in #75 🤦
LukeCarrier added a commit that referenced this pull request Nov 10, 2024
Broke this in #75 🤦
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility Issue with mkdocs-glightbox
1 participant