Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dockerfile): add postgresql-client for backups and restoring data #1

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

LuisFros
Copy link
Owner

@LuisFros LuisFros commented Feb 7, 2020

…bases from heroku

  • Se agregan los comandos desde Potassium para hacer backups y restore desde Heroku
  • Se instala el cliente de postgres en el contenedor para poder correr comandos con el cliente de postgres, por ej docker-compose run runner make restore-from-staging

@LuisFros LuisFros requested a review from rjherrera February 7, 2020 18:44
@LuisFros LuisFros changed the title feat(Dockefile): add postgresql-client for backups and restoring data feat(Dockerfile): add postgresql-client for backups and restoring data Feb 7, 2020
@@ -20,6 +20,11 @@ RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -\
&& apt-get update \
&& apt-get install -y yarn

# Add PostgreSQL to sources list
RUN echo "deb http://apt.postgresql.org/pub/repos/apt/ trusty-pgdg main" | tee /etc/apt/sources.list.d/pgdg.list \
&& wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es esa la "última" key disponible? o cuando expire el link va a cambiar?, no se si has visto acá que la url hace referencia a un nombre más genérico y se supone que en ese link siempre está la última, no se si ese nombre ACCC4CF8 hace referencia a una en específico y se irá a quedar obsoleta (trayéndonos dolor de cabeza cuando expire jaja)

Copy link
Owner Author

@LuisFros LuisFros Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es la Pub key que usan en general: https://wiki.postgresql.org/wiki/Apt

Por ejemplo si miras esta parte de los Dockerfiles de postgres:
https://github.com/docker-library/postgres/blob/b7cb3c6eacea93be2259381033be3cc435649369/9.6/Dockerfile#L39

Es un poco preocupante al principio que dice "Expires 2019-07-02" pero:
docker-library/postgres#623

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@LuisFros LuisFros merged commit d8a46af into master Feb 7, 2020
@LuisFros LuisFros deleted the feat-postgresql-client branch February 7, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants