Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-kit): Selection에 Disabled 안 먹는 이슈 수정 #86

Merged
merged 1 commit into from
Jun 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui-kit/src/components/Selection/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const Selection = (
onChange?.(e);
setInnerValue(e.target.value ?? '');
}}
disabled={disabled}
>
<option value="" hidden={true} className="lubycon-selection__placeholder">
{placeholder}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,10 @@
import React, { useEffect, useState } from 'react';
import { Meta } from '@storybook/react/types-6-0';
import { ProgressBar, Text } from 'src';
import { ProgressBarLabelPosition } from 'src/components/ProgressBar';
import { MAX_VALUE, labelPosition } from './data';

export default {
title: 'Components/ProgressBar',
} as Meta;

const MAX_VALUE = 100;
const getProgressValue = (value: number) => (value === MAX_VALUE ? 0 : value + 1);

export const Default = () => {
export const Preview = () => {
const [value, setValue] = useState(0);

useEffect(() => {
Expand All @@ -20,14 +14,9 @@ export const Default = () => {
};
}, []);

return (
<div>
<ProgressBar value={value} max={MAX_VALUE} />
</div>
);
return <ProgressBar value={value} max={MAX_VALUE} />;
};

const labelPosition: ProgressBarLabelPosition[] = ['top', 'bottom', 'left', 'right'];
export const Label = () => {
const [value, setValue] = useState(0);

Expand Down
4 changes: 4 additions & 0 deletions ui-kit/src/stories/Components/ProgressBar/data.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { ProgressBarLabelPosition } from 'src/components/ProgressBar';

export const MAX_VALUE = 100;
export const labelPosition: ProgressBarLabelPosition[] = ['top', 'bottom', 'left', 'right'];
31 changes: 31 additions & 0 deletions ui-kit/src/stories/Components/ProgressBar/index.stories.mdx
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { Meta, Story, Canvas } from '@storybook/addon-docs/blocks';
import { ProgressBar } from 'src';
import { Preview, Label, LabelFormatter } from './Components';

<Meta title="Components/ProgressBar" components={ProgressBar} />

# ProgressBar

## Preview

<Canvas>
<Story name="Preview">
<Preview />
</Story>
</Canvas>

## Label

<Canvas>
<Story name="Label">
<Label />
</Story>
</Canvas>

## Label Formatter

<Canvas>
<Story name="Label Formatter">
<LabelFormatter />
</Story>
</Canvas>
37 changes: 0 additions & 37 deletions ui-kit/src/stories/Components/Radio.stories.tsx

This file was deleted.

35 changes: 35 additions & 0 deletions ui-kit/src/stories/Components/Radio/index.stories.mdx
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import { Radio } from 'src';
import { Meta, Story, Canvas } from '@storybook/addon-docs/blocks';

<Meta title="Components/Radio" components={Radio} />

# Radio

## Preview

<Canvas>
<Story name="Preview">
<Radio label="라디오1" name="radio" />
<Radio label="라디오2" name="radio" />
</Story>
</Canvas>

## Disabled

<Canvas>
<Story name="Disabled">
<Radio label="라디오1" name="radio" />
<Radio label="라디오2" name="radio" />
<Radio label="라디오3" name="radio" disabled />
<Radio label="라디오4" name="radio" defaultChecked={true} disabled />
</Story>
</Canvas>

## Inline

<Canvas>
<Story name="Inline">
<Radio display="inline" label="라디오1" name="radio" style={{ marginRight: 16 }} />
<Radio display="inline" label="라디오2" name="radio" />
</Story>
</Canvas>
62 changes: 0 additions & 62 deletions ui-kit/src/stories/Components/Selection.stories.tsx

This file was deleted.

17 changes: 17 additions & 0 deletions ui-kit/src/stories/Components/Selection/Components.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import React, { useState } from 'react';
import { Selection, Text } from 'src';

export const Preview = () => {
const [state, setState] = useState('');

return (
<div>
<Selection onChange={(e) => setState(e.target.value)}>
<option>옵션1</option>
<option>옵션2</option>
<option>옵션3</option>
</Selection>
<Text style={{ display: 'block' }}>선택된 값은 {state}입니다.</Text>
</div>
);
};
58 changes: 58 additions & 0 deletions ui-kit/src/stories/Components/Selection/index.stories.mdx
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { Meta, Story, Canvas } from '@storybook/addon-docs/blocks';
import { Selection, Text } from 'src';
import { Preview } from './Components';

<Meta title="Components/Selection" components={Selection} />

# Selection

## Preview

<Canvas>
<Story name="Preview">
<Preview />
</Story>
</Canvas>

## Sizes

<Canvas>
<Story name="Sizes">
<ul>
{['small', 'medium', 'large'].map((size) => (
<li key={size} style={{ marginBottom: 16, listStyle: ' none' }}>
<Selection placeholder={size} size={size}>
<option>옵션1</option>
<option>옵션2</option>
<option>옵션3</option>
</Selection>
</li>
))}
</ul>
</Story>
</Canvas>

## Disabled

<Canvas>
<Story name="Disabled">
<Selection disabled>
<option>옵션1</option>
<option>옵션2</option>
<option>옵션3</option>
</Selection>
</Story>
</Canvas>

## Placeholder

<Canvas>
<Story name="Placeholder">
<Selection placeholder="어느 곳에 사시나요?">
<option>서울</option>
<option>경기</option>
<option>인천</option>
<option>충남</option>
</Selection>
</Story>
</Canvas>