feat(Flex): flex 컴포넌트를 원하는 컴포넌트로 렌더할 수 있도록 수정 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junkim93
reviewed
Feb 20, 2022
src/components/Flex/index.tsx
Outdated
| ref: Ref<any> | ||
| ) => { | ||
| const target = as ?? DEFAULT_ELEMENT; | ||
| const Component = target; |
There was a problem hiding this comment.
요거 target 말고 바로 Component 라는 상수명으로 할당해도 되지 않을까요 ?.?
따로 분리해주신 이유가 궁금합니당
There was a problem hiding this comment.
이거 예전에 Text 만들 당시에 뭔가 타입 평가가 제대로 안 되서 이렇게 했던 것 같은데, 지금 해보니까 제대로 평가가 되네유....?
바로 없애버리겠읍니다
There was a problem hiding this comment.
하는 김에 다른 애들도 같이 변경했슴다 cfdaa4e
Junkim93
approved these changes
Feb 22, 2022
lubycon-admin
pushed a commit
that referenced
this pull request
Feb 22, 2022
# [1.4.0](v1.3.0...v1.4.0) (2022-02-22) ### Features * **Flex:** flex 컴포넌트를 원하는 컴포넌트로 렌더할 수 있도록 수정 ([#139](#139)) ([a8d383c](a8d383c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
Flex컴포넌트가asProps는 받고 있는데 쓰지를 않고 있었네요. 이 값을 이용하여Flex를 사용할 때 원하는 컴포넌트로 렌더할 수 있게끔 변경합니다.집중적으로 리뷰 받고 싶은 부분이 있나요?
🙇