forked from containers/buildah
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
buildah: actually use containers.conf settings
Buildah ignores the container.conf settings. Commit 05d5d22 tried to fix this but I cannot see how this would have worked, there were also no test added related to containers.conf. The code below were we read the default just overwrites everything we already set so the config settings are ignored. Also there are many weird places were settings are just overwritten for no particular reason. The namespaces code path looks like mess to me. Namespaces are added/changed/removed in many different places and there is no explanation why. Maybe I am just not familar enough with this code base but I cannot really understand this. Hopefully a maintainer can take a closer look to see if my changes are indeed correct. Fixes containers/podman#13294 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
- Loading branch information
Showing
2 changed files
with
47 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters