Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCL and DCL must go to 0a in the event of Fet soft Charge and/or Discharge goes to off #1024

Closed
AlexdeKairos opened this issue Mar 27, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@AlexdeKairos
Copy link

AlexdeKairos commented Mar 27, 2024

Is your feature request related to a problem? Please describe.

Hi, I'm thinkig about scenarios with several batteries In parallel. In the event that one of the batteries goes to protection due to, for instance, an overload cell, and closes the charge, its CCL will remain untouched and the remaining batteries may become overcharged with more than its actual CCL. Same happens if during a high discharge one cell goes to protection and the BMS closes the discharge, its DCL should go to 0a to avoid the remaining batteries in parallel go to overdischarge.
Battery agregators sum the CCL to obtain whatever the chargers can put in the battery bank. Lets say we have 2 batteries with 100a CCL each. Chargers and MPPT will limit the max charge to 200a. If one of the bateries goes to protection and closes its Charge fets, the other battery will recive, if available, 200a for charge because the driver will still report 100a for each battery. Damaging its cells.

Describe the solution you'd like

In the event of a battery closes the charge, its associated CCL should go to 0a (reason maybe something like: Charge Closed by BMS . And as soon it's opened allowing to charge, it should go to whatever limit is calculated by the driver.

Similar with the discharge. If the battery closes the discharge, its DCL should go to 0a. (reason like: Discharge closed by BMS)
I understand that IO manu is not avail to control in all BMS through the driver but can be read in many BMSs brands.
Mine is JBD_BLE for instance.

Describe alternatives you've considered

No response

Additional context

No response

@AlexdeKairos AlexdeKairos added the enhancement New feature or request label Mar 27, 2024
@mr-manuel
Copy link
Collaborator

Do the Allow to charge and Allow to discharge switch to No in this cases, right?

@AlexdeKairos
Copy link
Author

Yes, if properly read, in my JBD_BLE works properly, it goes to "No" when battery BMS closes charge or discharge.

mr-manuel added a commit to mr-manuel/venus-os_dbus-serialbattery that referenced this issue Mar 28, 2024
mr-manuel added a commit to mr-manuel/venus-os_dbus-serialbattery that referenced this issue Mar 28, 2024
@mr-manuel
Copy link
Collaborator

Download the latest nightly and test please.

mr-manuel added a commit to mr-manuel/venus-os_dbus-serialbattery that referenced this issue Mar 31, 2024
* Set CCL/DCL to 0, if allow to charge/discharge is no, fixes Louisvdw#1024
* Check if ClassAndVrmInstance exists
@mr-manuel
Copy link
Collaborator

Enhancement included from driver version v1.2.20240401.

@AlexdeKairos
Copy link
Author

Hi Manuel, sorry but i've been busy all week without access to my boat. I have tried 1.2.20240401dev but in my JBD BLE bms the function is not working. One of my batteries is in Allow to Charge NO and Allow to discharge NO, and still the CCL is 115 and DCL is 150a. So mod is not working atm with JBD BLE.

@mr-manuel
Copy link
Collaborator

Please post a screenshot of the IO and Parameters page from the GUI.

@mr-manuel
Copy link
Collaborator

I found a typo. Please reinstall this version.

@AlexdeKairos
Copy link
Author

OK. Now the problem is that im not able to actually control the on off switches... they where already off and CCL and DCL are both Off on BMS. but I no longer can controll the switches. there was some issues already before. In my case, I had to manually switch on Both charge and discharge to make it work (the YES options) but right now they dont work anymore

@mr-manuel
Copy link
Collaborator

You can no longer control the switches through the dbus-serialbattery driver?

@AlexdeKairos
Copy link
Author

I can actually switch off discharge but can't go ON again from GUI. Switches actually go active or desactive but there is no change on Yes or No. I was able to force discharging OFF but the it does not respond anymore and YES is not avail. Balancing works both directions. For some reason charging off was not responding but after a several minutes delay, it went to No. no possible to recover to Yes regardless of the switch position.
Unfortunatelly today I must leave the boat but expect to come back tomorrow.

@mr-manuel
Copy link
Collaborator

Please open a new issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants