Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #10

Closed
wants to merge 1 commit into from
Closed

Update README #10

wants to merge 1 commit into from

Conversation

Louis-7
Copy link
Owner

@Louis-7 Louis-7 commented Apr 30, 2023

No description provided.

@ai-code-review
Copy link

🤖 Thanks for your pull request! AI reviewers will be checking it soon. Please make sure it follows our contribution guidelines and has passed our automated tests. 🤖💻

@@ -2,7 +2,7 @@

Ranking Board is an innovative project that utilizes free resources to build a website for recording people's effort. This repository serves as the dashboard of the Ranking Board. The back-end, which is a Github bot, is called [Ranking Board Helper](https://github.com/Louis-7/ranking-board-helper).

You may be curious about where the database is located. I use a JSON file, located at `data/ranking.json`, to store all the data. I utilize JavaScript code to convert it into the necessary data model.
You may be curious about where the database is located. I use a JSON file, located at `data/ranking.json`, to store all the data. I utilize JavaScript code to convert it into the necessary data model!

## Usage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code patch looks fine. However, I have a suggestion for improvement.

In the third line, instead of using an exclamation mark, I recommend using a period to communicate the message more clearly. So the updated line would be: "I utilize JavaScript code to convert it into the necessary data model."

Aside from that, I did not identify any bugs or risks in the code patch.

@Louis-7 Louis-7 changed the title test: update this file for test purpose. Update README May 14, 2023
@Louis-7 Louis-7 closed this Sep 2, 2023
@Louis-7 Louis-7 deleted the test branch September 2, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant