Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): stop export button dropdown from squishing #504

Conversation

Preston-Cook
Copy link
Contributor

@Preston-Cook Preston-Cook commented Feb 7, 2025

Before:
Screenshot 2025-02-07 at 1 46 33 PM

After:
Screenshot 2025-02-07 at 1 47 25 PM


This change is Reviewable

@Preston-Cook Preston-Cook changed the title fix(ui): stop import button dropdown from squishing fix(ui): stop export button dropdown from squishing Feb 7, 2025
@DereC4
Copy link
Member

DereC4 commented Feb 8, 2025

image

@DereC4
Copy link
Member

DereC4 commented Feb 8, 2025

image

@DereC4
Copy link
Member

DereC4 commented Feb 8, 2025

image

image

just making a note, but pressing the button then resizing breaks responsiveness while the usual behavior works fine.

Elie said this was ok so looks fine otherwise

Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samathingamajig Samathingamajig merged commit 846070e into Longhorn-Developers:main Feb 8, 2025
8 checks passed
@DereC4 DereC4 self-requested a review February 8, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants