Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(ui): changed tick marks to match x-axis #440

Conversation

seansy12232003
Copy link
Contributor

@seansy12232003 seansy12232003 commented Nov 18, 2024

Resolves #334
changed Grade Distribution Chart x-axis ticks stroke width to match Figma
Ticks were bigger than x-axis before and I changed the tick length to 1px to fix the inconsistency of tick to x-axis sizes.

Before:
Screenshot 2024-11-18 at 8 36 16 AM

After:
Screenshot 2024-11-18 at 8 37 11 AM


This change is Reviewable

changed Grade Distribution Chart x-axis ticks stroke width to match Figma
@DereC4 DereC4 requested a review from IsaDavRod November 18, 2024 23:05
@DereC4 DereC4 added the UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap label Nov 18, 2024
@DereC4 DereC4 added this to the v2.1.0 milestone Nov 18, 2024
Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaDavRod IsaDavRod merged commit 19e3838 into Longhorn-Developers:main Nov 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX-figma PRs that fulfill a task on the UI/UX & Feature Roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Grade Distribution Chart x-axis ticks stroke width to match Figma
3 participants