-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: schedule list item action menu #230
feat: schedule list item action menu #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! I'm surprised Isaiah didn't mention it, but let's line up the design style of the prompts to match those on the Figma (buttons, etc.).
Also, I would argue to remove the background on the triple dot menu icon.
src/views/components/common/DialogProvider/ScheduleListItemDialogProviders.tsx
Outdated
Show resolved
Hide resolved
src/views/components/common/DialogProvider/ScheduleListItemDialogProviders.tsx
Outdated
Show resolved
Hide resolved
src/views/components/common/DialogProvider/ScheduleListItemDialogProviders.tsx
Outdated
Show resolved
Hide resolved
src/views/components/common/DialogProvider/ScheduleListItemDialogProviders.tsx
Outdated
Show resolved
Hide resolved
src/views/components/common/DialogProvider/ScheduleListItemDialogProviders.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Menu works great! It is missing Figma styles for the border, padding, text and colors. Please fix the UI part and the PR should be good to go! Link to Figma component is here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a few more UI tweaks!
View the Figma Prototype (presenter):
- When hovering over an item, the hover fill should have rounded corners and should not touch the menu's borders. (idk how much of a hassle this would be tho)
- The menu's borders should be Secondary Colors/Off-white (just like the confirmation popup dialog's border when deleting a schedule)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM yayy
If u can Casey, remove the background on the triple dot menu icon like Elie suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job with this PR!
feat: floating menu for vertical dot popup for schedule list item component using @headlessui-float/react
feat: Schedule name will remain the same upon a rename if the schedule has a duplicate name of an existing schedule and it is renamed to the base name of the original schedule (ex. Schedule (2) is renamed to Schedule, and a schedule named Schedule already exists. It will stay as Schedule (2) instead of incrementing to 3).
feat: dialog popups added for deleting schedules and letting the user know deleting the active schedule is not allowed.
refactor: renaming a schedule an already existing name will be handled via "duplicate schedule logic"
refactor: creating a schedule will also be handled with "duplicate schedule logic" when making multiple new schedules at once
Demo:
Sept.28.Screen.Recording.2.mp4
Sept.28.Screen.Recording.mp4
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)