Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: some small changes for colors and font #201

Merged
merged 6 commits into from
Mar 30, 2024

Conversation

DereC4
Copy link
Member

@DereC4 DereC4 commented Mar 25, 2024

image


This change is Reviewable

Copy link
Member

@Razboy20 Razboy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DereC4)


src/views/components/PopupMain.tsx line 115 at r1 (raw file):

                    </div>
                    <div className='inline-flex items-center self-center gap-1'>
                        <Text variant='mini' className='text-ut-gray font-normal'>

Can you double check this works? I have a sneaking suspicion a ! is necessary here. Resolve once checked.

Code quote:

font-normal

Copy link
Member Author

@DereC4 DereC4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@DereC4 DereC4 requested a review from Razboy20 March 30, 2024 04:17
Copy link
Collaborator

@doprz doprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@doprz doprz merged commit bae1da4 into Longhorn-Developers:main Mar 30, 2024
6 of 7 checks passed
caseycharleston pushed a commit to caseycharleston/UT-Registration-Plus that referenced this pull request Mar 30, 2024
* fix: font weight added

* fix: change color hex

* fix: change color again

* fix: text-ut-burntorange

* fix: importance (tailwind wise)
@IsaDavRod
Copy link
Member

Issues with this:

Task #1
The UTRP color was changed correctly, but there was no change to the alignment of the text, which was something I requested in the task. Align text with icon. Notice how there's a bigger gap above the text than below the text. Let me know if this is not possible or is messy.

Task #2
Change "DATA LAST UPDATED" font weight to 400 was attempted and is correct on the Extension main popup but the text in the Calendar view is still heavy. Notice the difference in weight below:
Screenshot 2024-05-19 at 10 44 50 AM

Task #3
The color is changed in most places except for the course catalog course conflict highlight. The strikethrough is still the old red color, maybe it's hardcoded. Please change it to the new red color (UTRP Red #BF0000)
Screenshot 2024-05-19 at 10 47 21 AM

@DereC4
Copy link
Member Author

DereC4 commented May 22, 2024

new update incoming

@DereC4
Copy link
Member Author

DereC4 commented May 22, 2024

image
image

@DereC4
Copy link
Member Author

DereC4 commented May 22, 2024

image

Being overridden by something above

@IsaDavRod
Copy link
Member

how does it look if the weight is changed to 350 or 300? I just need it to look the same weight as the text in the main extension popup, even if they aren't the same weight value.

@DereC4
Copy link
Member Author

DereC4 commented May 22, 2024

ok i fixed it

@DereC4
Copy link
Member Author

DereC4 commented May 22, 2024

#224

doprz added a commit that referenced this pull request May 27, 2024
* fix: calendar weight change

* feat: small color change

* feat: stories for logo

* feat: align the logo

* feat: stupid imports

* fix: eslint styling

* Update CalenderHeader.tsx

* Update colors.module.scss

* chore: remove argTypes

* chore: remove argTypes

* chore: remove argTypes

* fix: lock

* chore: styled up logo stories

---------

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants