Skip to content

Commit

Permalink
chore: fix lint warnings (#385)
Browse files Browse the repository at this point in the history
  • Loading branch information
Samathingamajig authored Oct 23, 2024
1 parent 643ea13 commit eb30678
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 15 deletions.
9 changes: 8 additions & 1 deletion .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,14 @@ module.exports = {
},
],
'@typescript-eslint/no-explicit-any': 'error',
'@typescript-eslint/no-unused-vars': 'warn',
'@typescript-eslint/no-unused-vars': [
'warn',
{
argsIgnorePattern: '^_',
varsIgnorePattern: '^_',
caughtErrorsIgnorePattern: '^_',
},
],
'@typescript-eslint/naming-convention': 'off',
'@typescript-eslint/space-before-function-paren': 'off',
'@typescript-eslint/ban-ts-comment': 'off',
Expand Down
2 changes: 1 addition & 1 deletion src/pages/background/background.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ chrome.runtime.onInstalled.addListener(details => {
});

// migration/login logic
chrome.tabs.onUpdated.addListener(async (tabId, changeInfo, tab) => {
chrome.tabs.onUpdated.addListener(async (tabId, changeInfo) => {
// console.log(changeInfo);
if (changeInfo.url === 'https://utdirect.utexas.edu/apps/registrar/course_schedule/utrp_login/') {
function openPopupAction() {
Expand Down
2 changes: 1 addition & 1 deletion src/shared/util/icons.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import CancelledIcon from '~icons/material-symbols/warning';
export function StatusIcon(props: SVGProps<SVGSVGElement> & { status: StatusType }): JSX.Element | null {
const { status, ...rest } = props;

switch (props.status) {
switch (status) {
case Status.WAITLISTED:
return <WaitlistIcon {...rest} />;
case Status.CLOSED:
Expand Down
2 changes: 1 addition & 1 deletion src/views/components/PopupMain.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default function PopupMain(): JSX.Element {
}, []);

const [activeSchedule, schedules] = useSchedules();
const [isRefreshing, setIsRefreshing] = useState(false);
// const [isRefreshing, setIsRefreshing] = useState(false);
const [funny, setFunny] = useState<string>('');

useEffect(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/views/components/calendar/CalendarGrid.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function makeGridRow(row: number, cols: number): JSX.Element {
*/
export default function CalendarGrid({
courseCells,
saturdayClass, // TODO: implement/move away from props
saturdayClass: _saturdayClass, // TODO: implement/move away from props
setCourse,
}: React.PropsWithChildren<Props>): JSX.Element {
return (
Expand Down
2 changes: 1 addition & 1 deletion src/views/components/common/Chip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function Chip({ variant, label }: React.PropsWithChildren<Props>): JSX.El
default:
labelMap = {};
}
const longName = Object.entries(labelMap).find(([full, short]) => short === label)?.[0] ?? label;
const longName = Object.entries(labelMap).find(([_full, short]) => short === label)?.[0] ?? label;

return (
<Text
Expand Down
4 changes: 2 additions & 2 deletions src/views/components/common/Link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type Props = TextProps<'a'> & {
* A reusable Text component with props that build on top of the design system for the extension
*/
export default function Link(props: PropsWithChildren<Props>): JSX.Element {
let { className, href, ...passedProps } = props;
const { className, href, ...passedProps } = props;

if (href && !props.onClick) {
passedProps.onClick = e => {
Expand All @@ -37,7 +37,7 @@ export default function Link(props: PropsWithChildren<Props>): JSX.Element {
'underline cursor-pointer': !isDisabled,
'cursor-not-allowed color-ut-gray': isDisabled,
},
props.className
className
)}
/>
);
Expand Down
7 changes: 4 additions & 3 deletions src/views/components/settings/Settings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ const useDevMode = (targetCount: number): [boolean, () => void] => {
* @returns The Settings component.
*/
export default function Settings(): JSX.Element {
const [enableCourseStatusChips, setEnableCourseStatusChips] = useState<boolean>(false);
const [showTimeLocation, setShowTimeLocation] = useState<boolean>(false);
const [_enableCourseStatusChips, setEnableCourseStatusChips] = useState<boolean>(false);
const [_showTimeLocation, setShowTimeLocation] = useState<boolean>(false);
const [highlightConflicts, setHighlightConflicts] = useState<boolean>(false);
const [loadAllCourses, setLoadAllCourses] = useState<boolean>(false);
const [enableDataRefreshing, setEnableDataRefreshing] = useState<boolean>(false);
const [_enableDataRefreshing, setEnableDataRefreshing] = useState<boolean>(false);

const showMigrationDialog = useMigrationDialog();

Expand Down Expand Up @@ -216,6 +216,7 @@ export default function Settings(): JSX.Element {
try {
response = await fetch(link);
} catch (e) {
// eslint-disable-next-line no-alert
alert(`Failed to fetch url '${link}'`);
return;
}
Expand Down
4 changes: 0 additions & 4 deletions src/views/lib/CourseCatalogScraper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ const TableDataSelector = {
CORE_CURRICULUM: 'td[data-th="Core"] ul li',
} as const satisfies Record<string, string>;

type TableDataSelectorType = (typeof TableDataSelector)[keyof typeof TableDataSelector];

/**
* The selectors that we use to scrape the course details page for an individual course (https://utdirect.utexas.edu/apps/registrar/course_schedule/20239/52700/)
*/
Expand All @@ -32,8 +30,6 @@ const DetailsSelector = {
COURSE_DESCRIPTION: '#details p',
} as const;

type DetailsSelectorType = (typeof DetailsSelector)[keyof typeof DetailsSelector];

/**
* A class that allows us to scrape information from UT's course catalog to create our internal representation of a course
*/
Expand Down

0 comments on commit eb30678

Please sign in to comment.