Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle alternative offset formats #33

Closed
Sharparam opened this issue Feb 15, 2023 · 1 comment · Fixed by #34
Closed

Handle alternative offset formats #33

Sharparam opened this issue Feb 15, 2023 · 1 comment · Fixed by #34

Comments

@Sharparam
Copy link
Contributor

Sharparam commented Feb 15, 2023

Currently, you can specify an offset when setting a reminder, e.g.:

/remind 2023-02-14T20:00:00+01:00 Cry in bed because you're alone

However, the other common methods of specifying an offset (+01 for just hours, or +0100 for hours+minutes without a separator) do not work, because Python's "ISO" datetime parser is not ISO compliant.

Perhaps this should be detected and fixed manually within the parsing code in Lonabot? (Like we currently do for converting "Z" and "z" to "+00:00" because Python™.)

I'm prepared to work on this fix but not sure when I will have the time.

@9ary
Copy link
Contributor

9ary commented Feb 15, 2023

Considering python/cpython#80010 is already in python 3.11, I don't think we need to bother fixing this ourselves.

Lonami added a commit that referenced this issue Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants