-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OFFI-134: Add IMAP-specific functionality #455
Conversation
# Conflicts: # Lombiq.Tests.UI/Services/SmtpService.cs
# Conflicts: # Lombiq.Tests.UI/Extensions/EmailUITestContextExtensions.cs
# Conflicts: # Lombiq.Tests.UI/Services/SmtpService.cs
You ought to create a compatibility suppression file to fix this nuget validation failure. |
It says "Preferably, adjust the change to not be breaking if possible" so I might just go ahead and create a separate ctor so it won't be a breaking change. Update: Actually, never mind. It just doesn't make sense to do any of the workaround for this since nobody instantiates this class outside the library. |
# Conflicts: # Lombiq.Tests.UI/Services/SmtpService.cs
That advice is not applicable when you add a parameter to a constructor, and it's best to avoid multiple constructors as serializers don't like it. Also why did you add the new parameter in the middle? It's safer to add new parameters to the end (it doesn't matter with injected services but can be a problem with models). Also if it's not really required then give it a default value, but if it's required then leaving up the original ctor would be inappropriate. |
OFFI-134