Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFFI-134: Add IMAP-specific functionality #455

Merged
merged 13 commits into from
Feb 18, 2025
Merged

OFFI-134: Add IMAP-specific functionality #455

merged 13 commits into from
Feb 18, 2025

Conversation

barthamark
Copy link
Member

@barthamark barthamark commented Feb 8, 2025

@sarahelsaig
Copy link
Member

Error: /usr/share/dotnet/sdk/8.0.301/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP0002: Member 'Lombiq.Tests.UI.Services.SmtpServiceRunningContext.SmtpServiceRunningContext(int, System.Uri)' exists on [Baseline] lib/net8.0/Lombiq.Tests.UI.dll but not on lib/net8.0/Lombiq.Tests.UI.dll [/home/runner/work/UI-Testing-Toolbox/UI-Testing-Toolbox/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj]

You ought to create a compatibility suppression file to fix this nuget validation failure.

@barthamark
Copy link
Member Author

barthamark commented Feb 14, 2025

Error: /usr/share/dotnet/sdk/8.0.301/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP0002: Member 'Lombiq.Tests.UI.Services.SmtpServiceRunningContext.SmtpServiceRunningContext(int, System.Uri)' exists on [Baseline] lib/net8.0/Lombiq.Tests.UI.dll but not on lib/net8.0/Lombiq.Tests.UI.dll [/home/runner/work/UI-Testing-Toolbox/UI-Testing-Toolbox/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj]

You ought to create a compatibility suppression file to fix this nuget validation failure.

It says "Preferably, adjust the change to not be breaking if possible" so I might just go ahead and create a separate ctor so it won't be a breaking change.

Update: Actually, never mind. It just doesn't make sense to do any of the workaround for this since nobody instantiates this class outside the library.

@sarahelsaig
Copy link
Member

That advice is not applicable when you add a parameter to a constructor, and it's best to avoid multiple constructors as serializers don't like it. Also why did you add the new parameter in the middle? It's safer to add new parameters to the end (it doesn't matter with injected services but can be a problem with models). Also if it's not really required then give it a default value, but if it's required then leaving up the original ctor would be inappropriate.
Either way I suggest adding the suppression.

@sarahelsaig sarahelsaig merged commit 8c2c3bf into dev Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants