Skip to content

Commit

Permalink
Fix webroot argument that somehow corrupted the following environment…
Browse files Browse the repository at this point in the history 
… argument.
  • Loading branch information
@sarahelsaig
sarahelsaig committed Mar 6, 2022
1 parent 7a3ecb6 commit e70011d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Lombiq.Tests.UI/Services/OrchardCoreInstance.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public async Task<Uri> StartUpAsync()
argumentsBuilder = argumentsBuilder
.Add("--urls").Add(url)
.Add("--contentRoot").Add(_contentRootPath)
.Add("--webroot=").Add(Path.Combine(_contentRootPath, "wwwroot"))
.Add("--webroot=" + Path.Combine(_contentRootPath, "wwwroot"))

This comment has been minimized.

Sign in to view

Copy link
@0liver

0liver Mar 18, 2022

Contributor

Why does this one parameter use an = sign when the rest of them don't?

This comment has been minimized.

Sign in to view

Copy link
@sarahelsaig

sarahelsaig Mar 18, 2022

Author Member

Beats me, it was like this in the original commit.
However it's definitely true that if you use --key=value then there shouldn't be a space before or after the = as the whole pair needs to be a single param.

This comment has been minimized.

Sign in to view

Copy link
@0liver

0liver Mar 18, 2022 •
edited
Loading

Contributor

That for sure. It might just be an oversight that the = was there in the first place.
.Add("--environment").Add("Development");

if (!useExeToExecuteApp) argumentsBuilder = argumentsBuilder.Add(_configuration.AppAssemblyPath);
Expand Down

0 comments on commit e70011d

Please sign in to comment.