Merge branch 'issue/LMBQ-444' of https://github.com/Lombiq/UI-Testing…

…-Toolbox into issue/LMBQ-444

Lombiq.Tests.UI/Services/OrchardCoreUITestExecutorConfiguration.cs

@@ -123,16 +123,18 @@ public class OrchardCoreUITestExecutorConfiguration
     public Func<IWebApplicationInstance, Task> AssertAppLogsAsync { get; set; } = AssertAppLogsCanContainCacheFolderErrorsAsync;
 
     /// <summary>
-    /// Selects which response data get saved to <see cref="UITestContext.CumulativeBrowserLog"/>.
+    /// Gets or sets a delegate that selects which response data get saved to <see
+    /// cref="UITestContext.CumulativeBrowserLog"/>.
     /// </summary>
-    public Func<Entry, bool> BrowserLogFilter = IsNonSuccessBrowserLogEntry;
+    public Func<Entry, bool> BrowserLogFilter { get; set; } = IsNonSuccessBrowserLogEntry;
 
     public Action<IEnumerable<Entry>> AssertBrowserLog { get; set; } = AssertBrowserLogIsEmpty;
 
     /// <summary>
-    /// Selects which response data get saved to <see cref="UITestContext.CumulativeResponseLog"/>.
+    /// Gets or sets a delegate that selects which response data get saved to <see
+    /// cref="UITestContext.CumulativeResponseLog"/>.
     /// </summary>
-    public Func<ResponseCompletedEventArgs, bool> ResponseLogFilter = IsNonSuccessResponse;
+    public Func<ResponseCompletedEventArgs, bool> ResponseLogFilter { get; set; } = IsNonSuccessResponse;
 
     public Action<IEnumerable<ResponseData>> AssertResponseLog { get; set; } = AssertResponseLogIsEmpty;
 

Lombiq.Tests.UI/Services/UITestContext.cs

@@ -316,6 +316,10 @@ public static async Task<UITestContext> CreateAsync(
         {
             var biDi = await scope.Driver.AsBiDiAsync();
 
+            // We intentionally don't pass the UITestContext to these callbacks: The callbacks are called asynchronously
+            // by the browser (and Selenium), and e.g. the current URL can change between when a JS exception was thrown
+            // and the callback is called. Thus, BrowserLogFilter could e.g. ignore log entries for a URL that actually
+            // originated from a different URL and shouldn't be ignored.
             await biDi.Log.OnEntryAddedAsync(entry =>
             {
                 if (configuration.BrowserLogFilter(entry)) context._cumulativeBrowserLog.Enqueue(entry);