OSOE-935: Removing obsolete ui-test-parallelism, fixing blame hang dump merging #406
Conversation
github-actions
bot
changed the title
This reverts commit 700b6f8.
| @@ -28,7 +28,7 @@ function ItemFilter($Item, $TestConfiguration) | |||
| } | |||
|
|
|||
| $allow = (($Item.Name -like 'Sequence_*.xml') -or ($Item.Name -like '*_hangdump.dmp')) | |||
| if (-not ($allow -and $TestConfiguration)) | |||
| if (-not $allow -and $TestConfiguration) | |||
There was a problem hiding this comment.
I'm not sure about this, but this seems to be the original intent: if NOT $allow and if $TestConfiguration is set. This was the case before this change too: 0fdf57f (though the predecessor was syntactically incorrect).
Piedone
changed the title
This reverts commit 0382ad1.
| @@ -55,5 +55,6 @@ Get-ChildItem $testDirectory.Path -Recurse | | |||
| New-Item -Type Directory -Path $destinationDirectory | |||
| } | |||
|
|
|||
| Move-Item -Path $PSItem.FullName -Destination $destinationDirectory | |||
| # Moving the files would be faster, but the original files might only be readable by the current user. | |||
| Copy-Item -Path $PSItem.FullName -Destination $destinationDirectory | |||
There was a problem hiding this comment.
I used Move-Item here because - during the development - some runs ended with a not enough free disk space error. I don't know if this is still the case. Please consider to keep the Move-Item approach.
There was a problem hiding this comment.
I changed this because some ZAP files of the ZAP reports remained access denied, despite all my efforts (visible in the history, but I made sure that ZAP is absolutely shut down, also the whole of Docker, no other process is accessing the files, the permissions are correct). That broke blame hang dump collection in every single OSOCE run. I don't see any other solution than copying.
A blame hang dumps is less than a GB, BTW (see e.g. https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/12901077411), that should not be an issue even on a 2-core standard runner, let alone any larger ones (and all public projects on GitHub get the 4-core ones with more space).
OSOE-935