Replace Into with From for built-in types. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://doc.rust-lang.org/std/convert/trait.Into.html Prior to Rust 1.41, if the destination type was not part of the current crate then you couldn't implement From directly. This will fail to compile in older versions of the language because Rust's orphaning rules used to be a little bit more strict. To bypass this, you could implement Into directly. It is important to understand that Into does not provide a From implementation (as From does with Into). Therefore, you should always try to implement From and then fall back to Into if From can't be implemented. Signed-off-by: Sean Wilson <spwilson27@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://doc.rust-lang.org/std/convert/trait.Into.html
Prior to Rust 1.41, if the destination type was not part of the current
crate then you couldn't implement From directly. This will fail to
compile in older versions of the language because Rust's orphaning rules
used to be a little bit more strict. To bypass this, you could implement
Into directly.
It is important to understand that Into does not provide a From
implementation (as From does with Into). Therefore, you should always
try to implement From and then fall back to Into if From can't be
implemented.
Signed-off-by: Sean Wilson spwilson27@gmail.com