Convert BoxBytes
to/from boxed slices
#228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in a comment on the BoxBytes PR,
BoxBytes
logically can be converted to/from boxed slices as well as boxedSized
types. This PR extends the existingbox_bytes_of
/(try_)from_box_bytes
using sealed traits to allow them to take/return boxed slices as well as their current boxed Sized types (andBox<str>
forbox_bytes_of
).semver
The relaxation of the function bounds is not a breaking change.
The change from
impl<T: NoUninit> From<Box<T>> for BoxBytes
toimpl<T: ?Sized + BoxBytesOf> From<Box<T>> for BoxBytes
I believe is not a breaking change:From<Box<U>> for BoxBytes
must haveU
as a local, non-NoUninit
type, which as far as I can tell is still allowed under this new impl.