Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when sys_envs has level as string #98

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

jechol
Copy link
Contributor

@jechol jechol commented Oct 21, 2022

You can reproduce crash with

$ export LOGFLARE_LEVEL=debug

Error logs are

[error] :gen_event handler LogflareLogger.HttpBackend installed in Logger terminating
** (ArgumentError) argument error
    (kernel 8.4) logger.erl:621: :logger.compare_levels(:info, "debug")
    (logflare_logger_backend 0.11.0) lib/logflare_logger/http_backend.ex:172: LogflareLogger.HttpBackend.log_level_matches?/2
    (logflare_logger_backend 0.11.0) lib/logflare_logger/http_backend.ex:38: LogflareLogger.HttpBackend.handle_event/2
    (stdlib 4.0) gen_event.erl:793: :gen_event.server_update/4
    (stdlib 4.0) gen_event.erl:775: :gen_event.server_notify/4
    (stdlib 4.0) gen_event.erl:777: :gen_event.server_notify/4
    (stdlib 4.0) gen_event.erl:517: :gen_event.handle_msg/6
    (stdlib 4.0) proc_lib.erl:240: :proc_lib.init_p_do_apply/3
Last message: {:info, #PID<0.1527.0>, {Logger, "Elixir.LogflareLogger.HttpBackend v0.11.0 started.", {{2022, 10, 21}, {10, 47, 43, 707}}, [erl_level: :info, application: :logflare_logger_backend, domain: [:elixir], file: "lib/logflare_logger/http_backend.ex", function: "handle_info/2", gl: #PID<0.1527.0>, line: 48, mfa: {LogflareLogger.HttpBackend, :handle_info, 2}, module: LogflareLogger.HttpBackend, pid: #PID<0.1530.0>, time: 1666316863707591]}}
[error] GenServer #PID<0.1534.0> terminating
** (stop) {:EXIT, {:badarg, [{:logger, :compare_levels, [:info, "debug"], [file: 'logger.erl', line: 621]}, {LogflareLogger.HttpBackend, :log_level_matches?, 2, [file: 'lib/logflare_logger/http_backend.ex', line: 172]}, {LogflareLogger.HttpBackend, :handle_event, 2, [file: 'lib/logflare_logger/http_backend.ex', line: 38]}, {:gen_event, :server_update, 4, [file: 'gen_event.erl', line: 793]}, {:gen_event, :server_notify, 4, [file: 'gen_event.erl', line: 775]}, {:gen_event, :server_notify, 4, [file: 'gen_event.erl', line: 777]}, {:gen_event, :handle_msg, 6, [file: 'gen_event.erl', line: 517]}, {:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 240]}]}}
Last message: {:gen_event_EXIT, LogflareLogger.HttpBackend, {:EXIT, {:badarg, [{:logger, :compare_levels, [:info, "debug"], [file: 'logger.erl', line: 621]}, {LogflareLogger.HttpBackend, :log_level_matches?, 2, [file: 'lib/logflare_logger/http_backend.ex', line: 172]}, {LogflareLogger.HttpBackend, :handle_event, 2, [file: 'lib/logflare_logger/http_backend.ex', line: 38]}, {:gen_event, :server_update, 4, [file: 'gen_event.erl', line: 793]}, {:gen_event, :server_notify, 4, [file: 'gen_event.erl', line: 775]}, {:gen_event, :server_notify, 4, [file: 'gen_event.erl', line: 777]}, {:gen_event, :handle_msg, 6, [file: 'gen_event.erl', line: 517]}, {:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 240]}]}}}

@chasers chasers merged commit 0b99cea into Logflare:master Dec 1, 2022
@chasers
Copy link
Contributor

chasers commented Dec 1, 2022

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants