Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third parameter to the get_the_post_thumbnail call when it isn't boolean #74

Closed
wants to merge 2 commits into from

Conversation

EHLOVader
Copy link

This PR should fix the issue with the third parameter when it is passing an attr

Fixes #73

Pulled out separately because there is no instance where you would add `false` to the command while also using attributes for the image tag.
@EHLOVader
Copy link
Author

Updated the docs. But also ran into an issue within a loop where I couldn't just use two params, I had to fill out the whole thing.

@thumbnail(get_the_ID(),'medium', ['class' => 'w-full'])

With just
@thumbnail('medium', ['class' => 'w-full'])

It appeared to compile correctly, but no image was output. I believe that this is related to the loop and $post global not these changes.

@EHLOVader
Copy link
Author

Wondering if this looks good to merge? If it does can you merge it and add #hacktoberfest-accepted label to it? Thanks!

@Log1x Log1x mentioned this pull request Jul 29, 2023
@Log1x
Copy link
Owner

Log1x commented Jul 29, 2023

Superseded by #82

@Log1x Log1x closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use the attr parameter with the @thumbnail directive
2 participants