Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview and logged out state styling #194

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Overview and logged out state styling #194

merged 4 commits into from
Mar 13, 2023

Conversation

Arcslogger
Copy link
Member

also mightve ran prettier on a buncha things?


screenshots

image

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 507b3ab
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/640e9812edae950008b9f109
😎 Deploy Preview https://deploy-preview-194--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 507b3ab
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/640e981291fe380008c33934
😎 Deploy Preview https://deploy-preview-194--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@NicholasLin718 NicholasLin718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try rolling back your package-lock.json so there aren't 31k line changes :)

Copy link
Contributor

@NicholasLin718 NicholasLin718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roll back to either lock file 1 to match current or lock file 3 to match 0.4.2

Copy link
Contributor

@NicholasLin718 NicholasLin718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🥇 🚢

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to apply the same UI changes to the home page
image

@Ynng
Copy link
Member

Ynng commented Mar 13, 2023

Also the spacing/design is a little weird,
as in, the performance graphs are a darker color with no border,
but playerlist is a lighter color with border

the vertical spacing is also a little confusing, it might be nice to decrease the space between the "section subtitle"(All players that are currently online) and the "content" (Name), same for the graphs
image

@Ynng Ynng merged commit 1b22249 into 0.4.3 Mar 13, 2023
@Ynng Ynng deleted the overviewStyling branch March 13, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants