Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a right-click context menu to file viewer #178

Merged
merged 14 commits into from
Mar 9, 2023
Merged

Add a right-click context menu to file viewer #178

merged 14 commits into from
Mar 9, 2023

Conversation

seliayeu
Copy link
Contributor

@seliayeu seliayeu commented Mar 1, 2023

Added a right-click context menu. Alas, had to use Heroicons for the backspace icon.

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 559d198
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/6406b2811910d50008fc2073
😎 Deploy Preview https://deploy-preview-178--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seliayeu seliayeu linked an issue Mar 1, 2023 that may be closed by this pull request
4 tasks
@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 559d198
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/6406b2814b824700088f55c1
😎 Deploy Preview https://deploy-preview-178--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a couple small issues I commented about

src/components/Atoms/ContextMenuButton.tsx Outdated Show resolved Hide resolved
src/components/FileViewer/CreateFileModal.tsx Outdated Show resolved Hide resolved
src/components/FileViewer/FileList.tsx Show resolved Hide resolved
src/components/FileViewer/FileList.tsx Outdated Show resolved Hide resolved
src/components/FileViewer/FileList.tsx Outdated Show resolved Hide resolved
src/components/FileViewer/FileList.tsx Outdated Show resolved Hide resolved
src/components/FileViewer/FileList.tsx Show resolved Hide resolved
src/components/FileViewer/FileViewer.tsx Show resolved Hide resolved
src/components/FileViewer/FileContextMenu.tsx Outdated Show resolved Hide resolved
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, meant to say request changes

@Ynng
Copy link
Member

Ynng commented Mar 5, 2023

oh shoot I didn't realize the base is wrong.
This PR should have 0.4.3 as a base, not main

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please change the base to 0.4.3 and handle potential merge conflicts, sry for not noticing this earlier

@Ynng
Copy link
Member

Ynng commented Mar 5, 2023

Oh sorry I meant this one
image

@seliayeu seliayeu changed the base branch from main to 0.4.3 March 5, 2023 23:05
@Ynng
Copy link
Member

Ynng commented Mar 5, 2023

image
the dashboard (not login pages) crash on launch immediately

@Ynng
Copy link
Member

Ynng commented Mar 6, 2023

Everything works great.
It would be nice to add right-click context menu to the empty area at the bottom as well though, maybe remove options such as copy/cut but keep options like paste and new file.

image

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! impressive work!

@seliayeu seliayeu merged commit 559d198 into 0.4.3 Mar 9, 2023
@Ynng Ynng deleted the context-menu branch May 12, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right click/context menu in file viewer
2 participants