Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify error graphics #157

Closed
Ynng opened this issue Feb 18, 2023 · 1 comment · Fixed by #184
Closed

Unify error graphics #157

Ynng opened this issue Feb 18, 2023 · 1 comment · Fixed by #184
Assignees
@kevinzhang03
Milestone
0.4.3

Comments

@Ynng
Copy link
Member

Ynng commented Feb 18, 2023

Some examples of what I'm talking about

Image
Image

Currently these errors are hard coded wherever they are needed.
We should unify them and make it one component instead.
Call it ErrorGraphics or WarningIllustration or whatever is fitting.

You can easily find existing hard-coded implementations of these by searching for <FontAwesomeIcon globally in vscode
@Ynng Ynng added this to Lodestone Feb 18, 2023
@Ynng Ynng converted this from a draft issue Feb 18, 2023
@Ynng Ynng moved this from 🗃 Draft/Backlog to 🔖 Ready to Start in Lodestone Feb 18, 2023
@Ynng Ynng added this to the 0.4.3 milestone Feb 25, 2023
@kevinzhang03 kevinzhang03 moved this from 🔖 Ready to Start to 💻 In Progress in Lodestone Mar 3, 2023
@kevinzhang03 kevinzhang03 mentioned this issue Mar 4, 2023
Merged
@kevinzhang03 kevinzhang03 moved this from 💻 In Progress to 👀 In Review in Lodestone Mar 4, 2023
kevinzhang03 added a commit that referenced this issue Mar 4, 2023
@kevinzhang03
Merge pull request #184 from Lodestone-Team/157-unify-error
e04235d 
#157 Unify errors into a single component
@Arcslogger Arcslogger linked a pull request Mar 4, 2023 that will close this issue
#157 Unify errors into a single component #184
Merged
@Arcslogger Arcslogger moved this from 👀 In Review to ✔ Done in Lodestone Mar 4, 2023
@Arcslogger
Copy link
Member

make sure ur linking PRs to issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinzhang03 kevinzhang03

Labels
None yet
Projects
Lodestone
Status: ✔ Done
Milestone
0.4.3
Development

Successfully merging a pull request may close this issue.

#157 Unify errors into a single component Lodestone-Team/lodestone
3 participants
@kevinzhang03 @Ynng @Arcslogger