Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember 3.0 compatibility (use ember-d3 ^0.4.0) #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jdurand
Copy link

@jdurand jdurand commented Feb 22, 2018

ember-d3 ^0.3.0 with ember 3.0.0 produces the following error:

=================================================================================

ERROR Summary:

  - broccoliBuilderErrorStack: [undefined]
  - codeFrame: [undefined]
  - errorMessage: Path must be a string. Received undefined
  - errorType: [undefined]
  - location:
    - column: [undefined]
    - file: [undefined]
    - line: [undefined]
  - message: Path must be a string. Received undefined
  - name: TypeError
  - nodeAnnotation: [undefined]
  - nodeName: [undefined]
  - originalErrorMessage: [undefined]
  - stack: TypeError: Path must be a string. Received undefined
  at assertPath (path.js:28:11)
  at Object.join (path.js:1251:7)
  at module.exports ([PROJECT PATH]/node_modules/ember-d3/lib/d3-deps-for-package.js:37:10)
  at Class._getAllD3Modules ([PROJECT PATH]/node_modules/ember-d3/index.js:87:12)
  at Class.getD3Modules ([PROJECT PATH]/node_modules/ember-d3/index.js:77:27)
  at Class.included ([PROJECT PATH]/node_modules/ember-d3/index.js:51:27)
  at Class.superWrapper [as included] ([PROJECT PATH]/node_modules/core-object/lib/assign-properties.js:34:20)
  at addons.reduce ([PROJECT PATH]/node_modules/ember-cli/lib/models/addon.js:383:26)
  at Array.reduce (<anonymous>:null:null)
  at Class.eachAddonInvoke ([PROJECT PATH]/node_modules/ember-cli/lib/models/addon.js:380:24)
  at Class.included ([PROJECT PATH]/node_modules/ember-cli/lib/models/addon.js:656:10)
  at Class.superWrapper [as included] ([PROJECT PATH]/node_modules/core-object/lib/assign-properties.js:34:20)
  at Class.included ([PROJECT PATH]/node_modules/ember-d3-helpers/index.js:12:26)
  at Class.superWrapper [as included] ([PROJECT PATH]/node_modules/core-object/lib/assign-properties.js:34:20)
  at project.addons.project.addons.filter.addon ([PROJECT PATH]/node_modules/ember-cli/lib/broccoli/ember-app.js:538:17)
  at Array.filter (<anonymous>:null:null)
  at EmberApp._notifyAddonIncluded ([PROJECT PATH]/node_modules/ember-cli/lib/broccoli/ember-app.js:535:47)
  at new EmberApp ([PROJECT PATH]/node_modules/ember-cli/lib/broccoli/ember-app.js:164:10)
  at module.exports ([PROJECT PATH]/ember-cli-build.js:9:13)
  at Builder.setupBroccoliBuilder ([PROJECT PATH]/node_modules/ember-cli/lib/models/builder.js:51:19)
  at new Builder ([PROJECT PATH]/node_modules/ember-cli/lib/models/builder.js:29:10)
  at ServeTask.run ([PROJECT PATH]/node_modules/ember-cli/lib/tasks/serve.js:24:55)
  at Promise.resolve.then ([PROJECT PATH]/node_modules/ember-cli/lib/models/command.js:243:46)
  at tryCatcher ([PROJECT PATH]/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:323:19)
  at invokeCallback ([PROJECT PATH]/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:495:31)
  at [PROJECT PATH]/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:559:14
  at flush ([PROJECT PATH]/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:2402:5)
  at _combinedTickCallback (internal/process/next_tick.js:131:7)
  at process._tickCallback (internal/process/next_tick.js:180:9)


=================================================================================

@geoffreyd
Copy link

Any chance we can get this merged? We're keen to move to ember 3, and would rather not have to point at a git branch.

@ghost
Copy link

ghost commented Jun 25, 2018

@geoffreyd we have a WIP PR for upgrading to Ember 3 here #46 -- would you be up taking on some (or all) of the last steps suggested by JacobQ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants