Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure functional tests pass on push event #46

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

Revert a change made in #38 and #42.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #46 (f1d5adb) into master (8bcdda9) will increase coverage by 11.90%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #46       +/-   ##
===========================================
+ Coverage   85.71%   97.61%   +11.90%     
===========================================
  Files           1        1               
  Lines         168      168               
===========================================
+ Hits          144      164       +20     
+ Misses         24        4       -20     

see 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 3da1cf6 into master Dec 9, 2023
18 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-ensure-functional-tests-pass-on-push-event branch December 9, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant