Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use github context instead of events API #107

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jul 14, 2024

Description

The GitHub events API can be delayed between 30 seconds and 6 hours (https://docs.github.com/en/rest/activity/events?apiVersion=2022-11-28#list-repository-events). Due to this, we are going to force using squash and merging and get the timestamp from the provided github context.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c56dda1) to head (929a88a).

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #107      +/-   ##
===========================================
+ Coverage   97.24%   100.00%   +2.75%     
===========================================
  Files           1         1              
  Lines         145       153       +8     
===========================================
+ Hits          141       153      +12     
+ Misses          4         0       -4     
Files Coverage Δ
action/main.py 100.00% <100.00%> (+2.75%) ⬆️

@ReenigneArcher ReenigneArcher force-pushed the fix!-use-github-context-instead-of-events-API branch 11 times, most recently from d040c23 to 0527d0a Compare July 14, 2024 15:16
@ReenigneArcher ReenigneArcher force-pushed the fix!-use-github-context-instead-of-events-API branch from 0527d0a to 929a88a Compare July 14, 2024 15:26
@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 14, 2024 15:32
@ReenigneArcher ReenigneArcher merged commit fc138bd into master Jul 14, 2024
11 checks passed
@ReenigneArcher ReenigneArcher deleted the fix!-use-github-context-instead-of-events-API branch July 14, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant