Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release_body): do not mention contributors #105

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

  • Replace GitHub usernames with markdown profile URL in release notes
  • Replace PR URLs with markdown URLs in release notes

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the fix(release_body)-do-not-mention-contributors branch from 78c19ab to c27444e Compare July 13, 2024 21:02
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.62%. Comparing base (b4d4ee5) to head (1fbc2ad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   98.27%   98.62%   +0.34%     
==========================================
  Files           1        1              
  Lines         116      145      +29     
==========================================
+ Hits          114      143      +29     
  Misses          2        2              
Files Coverage Δ
action/main.py 98.62% <93.33%> (+0.34%) ⬆️

action/main.py Outdated
"""
# replace contributor mentions with GitHub profile
processed_body = ''
re_username = re.compile(r'@([a-zA-z\d-]{0,38})')

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium

Suspicious character range that overlaps with a-z in the same character class, and is equivalent to [A-Z[]^_`a-z].
action/main.py Outdated
# replace contributor mentions with GitHub profile
processed_body = ''
re_username = re.compile(r'@([a-zA-z\d-]{0,38})')
re_pr_url = re.compile(r'(https://github\.com/([a-zA-z\d-]{0,38})/([a-zA-Z\d-]+)/pull/(\d+))')

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium

Suspicious character range that overlaps with a-z in the same character class, and is equivalent to [A-Z[]^_`a-z].
@ReenigneArcher ReenigneArcher force-pushed the fix(release_body)-do-not-mention-contributors branch from c27444e to c464edf Compare July 13, 2024 21:17
@ReenigneArcher ReenigneArcher force-pushed the fix(release_body)-do-not-mention-contributors branch from c464edf to 1fbc2ad Compare July 13, 2024 21:18
@ReenigneArcher ReenigneArcher merged commit c56dda1 into master Jul 13, 2024
10 of 11 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(release_body)-do-not-mention-contributors branch July 13, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant