Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not build docs for external projects #94

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Do not build docs for external projects. Sunshine and libdd are fighting over target names otherwise.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this change to https://github.com/LizardByte/tray as well?

Otherwise, I need to wait to merge this until I can get to that.

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Aug 9, 2024

This might be a hint to the issues with coverage in the this repo.
image

@FrogTheFrog
Copy link
Collaborator Author

FrogTheFrog commented Aug 9, 2024

This might be a hint to the issues with coverage in the this repo. image

On MacOS it simply failed to upload... Unless you're talking about something else

@ReenigneArcher
Copy link
Member

That was Linux:
image

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (b30c2e1) to head (2b6adf2).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files          32       32           
  Lines        1820     1820           
  Branches     1014     1014           
=======================================
  Hits         1708     1708           
- Misses         49       58    +9     
+ Partials       63       54    -9     
Flag Coverage Δ
Linux 89.56% <ø> (ø)
Windows 93.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit d4afa3c into LizardByte:master Aug 9, 2024
22 checks passed
@FrogTheFrog FrogTheFrog deleted the patch-1 branch August 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants