Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic re-routeable logger #9

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Add a basic re-routable logger (with the intention of connecting to Sunshine later on) that follows
the BOOST_LOG(info) << ... pattern for a drop-in replacement when porting the code.

Additionally C++ is bumped to 20 and some other minor cleanup was performed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 70.21%. Comparing base (7ad938f) to head (b9743a4).

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
+ Coverage        0   70.21%   +70.21%     
===========================================
  Files           0        2        +2     
  Lines           0       47       +47     
  Branches        0       15       +15     
===========================================
+ Hits            0       33       +33     
- Misses          0        1        +1     
- Partials        0       13       +13     
Flag Coverage Δ
Windows 70.21% <70.21%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/logging.h 50.00% <50.00%> (ø)
src/logging.cpp 71.11% <71.11%> (ø)

ReenigneArcher

This comment was marked as resolved.

@FrogTheFrog

This comment was marked as resolved.

@ReenigneArcher

This comment was marked as resolved.

@FrogTheFrog

This comment was marked as resolved.

@ReenigneArcher

This comment was marked as resolved.

ReenigneArcher
ReenigneArcher previously approved these changes Apr 16, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher ReenigneArcher merged commit b4d8297 into LizardByte:master Apr 16, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants