Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Sunshine compatibility #67

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Improve Sunshine compatibility by adding fatal log level and also improving compatibility with older compilers.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) July 19, 2024 16:05
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.79%. Comparing base (693fb9f) to head (f0f4867).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   93.95%   93.79%   -0.16%     
==========================================
  Files          34       34              
  Lines        1836     1822      -14     
  Branches     1026     1010      -16     
==========================================
- Hits         1725     1709      -16     
- Misses         50       58       +8     
+ Partials       61       55       -6     
Flag Coverage Δ
Linux 89.37% <88.88%> (-1.22%) ⬇️
Windows 93.73% <88.88%> (-0.16%) ⬇️
macOS 69.38% <41.17%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/file_settings_persistence.cpp 55.00% <100.00%> (ø)
src/common/include/display_device/logging.h 100.00% <ø> (ø)
src/common/logging.cpp 95.08% <88.23%> (-3.59%) ⬇️

@ReenigneArcher ReenigneArcher disabled auto-merge July 19, 2024 16:40
@ReenigneArcher ReenigneArcher merged commit d435ad9 into LizardByte:master Jul 19, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants