Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upload coverage in separate job matrix #29

Merged
merged 1 commit into from
May 9, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Attempt to improve re-running failed coverage uploads, by not having to re-build/test the whole project.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci-upload-coverage-in-separate-job-matrix branch 2 times, most recently from 3fd0495 to 2b46a0b Compare May 9, 2024 17:16
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.82%. Comparing base (8c69e42) to head (06349ca).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   71.42%   67.82%   -3.61%     
==========================================
  Files           7        9       +2     
  Lines         322      345      +23     
  Branches      177      177              
==========================================
+ Hits          230      234       +4     
- Misses         39       58      +19     
  Partials       53       53              
Flag Coverage Δ
Linux 68.33% <ø> (-10.40%) ⬇️
Windows 70.38% <ø> (-2.08%) ⬇️
macOS 50.00% <ø> (-1.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci-upload-coverage-in-separate-job-matrix branch 2 times, most recently from bee78af to 664c83f Compare May 9, 2024 17:30
@ReenigneArcher ReenigneArcher force-pushed the ci-upload-coverage-in-separate-job-matrix branch from 664c83f to 06349ca Compare May 9, 2024 17:32
@ReenigneArcher ReenigneArcher marked this pull request as ready for review May 9, 2024 17:43
@ReenigneArcher ReenigneArcher merged commit cc2d362 into master May 9, 2024
21 checks passed
@ReenigneArcher ReenigneArcher deleted the ci-upload-coverage-in-separate-job-matrix branch May 9, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant